linux-kernel - Re: [PATCH] pmdomain: ti: Select PM_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8107b20a-b0f1-4724-8ab7-994ede3b3268@baylibre.com>
Date: Wed, 9 Jul 2025 14:29:25 +0200
From: Guillaume La Roque <glaroque@...libre.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: vigneshr@...com, nm@...com, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, vishalm@...com
Subject: Re: [PATCH] pmdomain: ti: Select PM_GENERIC_DOMAINS

Le 09/07/2025 à 13:09, Ulf Hansson a écrit :
> On Fri, 4 Jul 2025 at 11:08, Guillaume La Roque <glaroque@...libre.com> wrote:
>> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
>> it is always enabled when TI_SCI_PM_DOMAINS is selected. This
>> simplifies the configuration process and prevents build errors
>> if PM_GENERIC_DOMAINS is not explicitly enabled.
>>
>> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
>> ---
>>   drivers/pmdomain/ti/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
>> index 67c608bf7ed0..35a4c73da17a 100644
>> --- a/drivers/pmdomain/ti/Kconfig
>> +++ b/drivers/pmdomain/ti/Kconfig
>> @@ -10,7 +10,7 @@ if SOC_TI
>>   config TI_SCI_PM_DOMAINS
>>          tristate "TI SCI PM Domains Driver"
>>          depends on TI_SCI_PROTOCOL
>> -       depends on PM_GENERIC_DOMAINS
>> +       select PM_GENERIC_DOMAINS
> You need an "if PM" too here. So:
>
> select PM_GENERIC_DOMAINS if PM

ah yes sorry i forgot it.

i'll fix in v2


thanks for review

Guillaume

>
>>          help
>>            Generic power domain implementation for TI device implementing
>>            the TI SCI protocol.
>>
>> ---
>> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
>> change-id: 20250704-depspmdomain-2c584745dca8
>>
>> Best regards,
>> --
>> Guillaume La Roque <glaroque@...libre.com>
>>
> Kind regards
> Uffe