linux-kernel - Re: [PATCH v4 6/8] char: misc: Does not request module for miscdevice with dynamic minor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dabb7247-1b76-407f-b22f-c1ebd9ab9dd5@icloud.com>
Date: Wed, 9 Jul 2025 20:46:26 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Arnd Bergmann <arnd@...db.de>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 Helge Deller <deller@....de>, "David S. Miller" <davem@...emloft.net>,
 Andreas Larsson <andreas@...sler.com>,
 Thadeu Lima de Souza Cascardo <cascardo@...lia.com>,
 linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
 sparclinux@...r.kernel.org, Zijun Hu <zijun.hu@....qualcomm.com>
Subject: Re: [PATCH v4 6/8] char: misc: Does not request module for miscdevice
 with dynamic minor

On 2025/7/6 16:55, Greg Kroah-Hartman wrote:
>> -		if (!new_fops)
>> -			goto fail;
>>  	}
>>  
>> +	if (!new_fops)
>> +		goto fail;
>> +
> This is fine, but is it going to break any existing users that happened
> to rely on this behaviour?

no since there are no kernel users who register miscdevice with minor > 255.