linux-kernel - Re: [PATCH] fbcon: Fix outdated registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG5urDySjLCCj86J@phenom.ffwll.local>
Date: Wed, 9 Jul 2025 15:29:16 +0200
From: Simona Vetter <simona.vetter@...ll.ch>
To: oushixiong1025@....com
Cc: Simona Vetter <simona@...ll.ch>, Helge Deller <deller@....de>,
	linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, Shixiong Ou <oushixiong@...inos.cn>
Subject: Re: [PATCH] fbcon: Fix outdated registered_fb reference in comment

On Wed, Jul 09, 2025 at 06:34:38PM +0800, oushixiong1025@....com wrote:
> From: Shixiong Ou <oushixiong@...inos.cn>
> 
> The variable was renamed to fbcon_registered_fb, but this comment was
> not updated along with the change. Correct it to avoid confusion.
> 
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>

I've added the right Fixes: line and merged this to drm-misc-next, thanks
for your patch.
-Sima

> ---
>  drivers/video/fbdev/core/fbcon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 25684f5d6523..d8eab4859fd4 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -953,13 +953,13 @@ static const char *fbcon_startup(void)
>  	int rows, cols;
>  
>  	/*
> -	 *  If num_registered_fb is zero, this is a call for the dummy part.
> +	 *  If fbcon_num_registered_fb is zero, this is a call for the dummy part.
>  	 *  The frame buffer devices weren't initialized yet.
>  	 */
>  	if (!fbcon_num_registered_fb || info_idx == -1)
>  		return display_desc;
>  	/*
> -	 * Instead of blindly using registered_fb[0], we use info_idx, set by
> +	 * Instead of blindly using fbcon_registered_fb[0], we use info_idx, set by
>  	 * fbcon_fb_registered();
>  	 */
>  	info = fbcon_registered_fb[info_idx];
> -- 
> 2.25.1
> 

-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch