linux-kernel - Re: [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DB76FN8WH6HK.1LST75877I45J@umich.edu>
Date: Tue, 08 Jul 2025 22:42:45 -0400
From: "Trevor Gross" <tmgross@...ch.edu>
To: Onur Özkan <work@...rozkan.dev>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-pm@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
 <kunit-dev@...glegroups.com>
Cc: <airlied@...il.com>, <simona@...ll.ch>, <ojeda@...nel.org>,
 <alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, <lossin@...nel.org>, <a.hindborg@...nel.org>,
 <aliceryhl@...gle.com>, <rafael@...nel.org>, <viresh.kumar@...aro.org>,
 <gregkh@...uxfoundation.org>, <maarten.lankhorst@...ux.intel.com>,
 <mripard@...nel.org>, <tzimmermann@...e.de>, <davidgow@...gle.com>,
 <nm@...com>
Subject: Re: [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in
 nova-core/regs.rs

On Tue Jul 1, 2025 at 1:35 AM EDT, Onur Özkan wrote:
> This makes it clear that the warning is expected not just
> ignored, so we don't end up having various unnecessary
> linting rules in the codebase.
>
> Some parts of the codebase already use this approach, this
> patch just applies it more broadly.
>
> No functional changes.
>
> Signed-off-by: Onur Özkan <work@...rozkan.dev>
> ---
>  drivers/gpu/nova-core/regs.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> index 5a1273230306..87e5963f1ebb 100644
> --- a/drivers/gpu/nova-core/regs.rs
> +++ b/drivers/gpu/nova-core/regs.rs
> @@ -2,7 +2,7 @@
>
>  // Required to retain the original register names used by OpenRM, which are all capital snake case
>  // but are mapped to types.
> -#![allow(non_camel_case_types)]
> +#![expect(non_camel_case_types)]
>
>  #[macro_use]
>  mod macros;
> --
> 2.50.0

Reviewed-by: Trevor Gross <tmgross@...ch.edu>