linux-kernel - Re: [PATCH net v2 1/3] net: phy: enable polling when driver implements get_next_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <248bbbcf-ec7a-4ae4-a502-8f2575c18bbb@lunn.ch>
Date: Wed, 9 Jul 2025 16:03:13 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	Andre Edich <andre.edich@...rochip.com>,
	Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net v2 1/3] net: phy: enable polling when driver
 implements get_next_update_time

On Wed, Jul 09, 2025 at 12:42:08PM +0200, Oleksij Rempel wrote:
> Currently, phy_polling_mode() enables polling only if:
> - the PHY is in interrupt-less mode, or
> - the driver provides an update_stats() callback.
> 
> This excludes drivers that implement get_next_update_time()
> to support adaptive polling but do not provide update_stats().
> As a result, the state machine timer will not run, and the
> get_next_update_time() callback is never used.
> 
> This patch extends the polling condition to include drivers that
> implement get_next_update_time(). This change is required to support
> adaptive polling in the SMSC LAN9512/LAN8700 PHY family, which cannot
> reliably use interrupts.
> 
> No in-tree drivers rely on this mechanism yet, so existing behavior is
> unchanged. If any out-of-tree driver incorrectly implements
> get_next_update_time(), enabling polling is still the correct behavior.
> 
> Fixes: 8bf47e4d7b87 ("net: phy: Add support for driver-specific next update time")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew