linux-kernel - Re: [PATCH net v1 1/2] net: phy: microchip: Use genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3b54e33-30be-4c05-af87-c7833213bd55@lunn.ch>
Date: Wed, 9 Jul 2025 16:16:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Arun Ramadoss <arun.ramadoss@...rochip.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Yuiko Oshino <yuiko.oshino@...rochip.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH net v1 1/2] net: phy: microchip: Use genphy_soft_reset()
 to purge stale LPA bits

On Wed, Jul 09, 2025 at 03:07:52PM +0200, Oleksij Rempel wrote:
> Enable .soft_reset for the LAN88xx PHY driver by assigning
> genphy_soft_reset() to ensure that the phylib core performs a proper
> soft reset during reconfiguration.
> 
> Previously, the driver left .soft_reset unimplemented, so calls to
> phy_init_hw() (e.g., from lan88xx_link_change_notify()) did not fully
> reset the PHY. As a result, stale contents in the Link Partner Ability
> (LPA) register could persist, causing the PHY to incorrectly report
> that the link partner advertised autonegotiation even when it did not.
> 
> Using genphy_soft_reset() guarantees a clean reset of the PHY and
> corrects the false autoneg reporting in these scenarios.
> 
> Fixes: ccb989e4d1ef ("net: phy: microchip: Reset LAN88xx PHY to ensure clean link state on LAN7800/7850")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew