linux-kernel - Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec773987-b6d8-4fe9-bca9-a41009f27d80@linux.intel.com>
Date: Wed, 9 Jul 2025 07:21:01 -0700
From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko <andy@...nel.org>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Srinivas Neeli <srinivas.neeli@....com>, Michal Simek
 <michal.simek@....com>, Nandor Han <nandor.han@...com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 patches@...nsource.cirrus.com, linux-arm-kernel@...ts.infradead.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter
 callbacks


On 7/8/25 11:41 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---

Looks good.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>   drivers/gpio/gpio-wcove.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index 1ec24f6f9300f33f5b3f0f8deb539e08392b8188..c50b74ced6364e3c3cfbe9ed385d21c80a2bb2e7 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -200,18 +200,18 @@ static int wcove_gpio_get(struct gpio_chip *chip, unsigned int gpio)
>   	return val & 0x1;
>   }
>   
> -static void wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)
> +static int wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)
>   {
>   	struct wcove_gpio *wg = gpiochip_get_data(chip);
>   	int reg = to_reg(gpio, CTRL_OUT);
>   
>   	if (reg < 0)
> -		return;
> +		return 0;
>   
>   	if (value)
> -		regmap_set_bits(wg->regmap, reg, 1);
> -	else
> -		regmap_clear_bits(wg->regmap, reg, 1);
> +		return regmap_set_bits(wg->regmap, reg, 1);
> +
> +	return regmap_clear_bits(wg->regmap, reg, 1);
>   }
>   
>   static int wcove_gpio_set_config(struct gpio_chip *chip, unsigned int gpio,
> @@ -442,7 +442,7 @@ static int wcove_gpio_probe(struct platform_device *pdev)
>   	wg->chip.direction_output = wcove_gpio_dir_out;
>   	wg->chip.get_direction = wcove_gpio_get_direction;
>   	wg->chip.get = wcove_gpio_get;
> -	wg->chip.set = wcove_gpio_set;
> +	wg->chip.set_rv = wcove_gpio_set;
>   	wg->chip.set_config = wcove_gpio_set_config;
>   	wg->chip.base = -1;
>   	wg->chip.ngpio = WCOVE_VGPIO_NUM;
>
-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer