linux-kernel - Re: [PATCH v2 2/2] bitfield: Ensure the return values of helper functions are checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG6LtJ2N1smBKHh1@yury>
Date: Wed, 9 Jul 2025 11:33:08 -0400
From: Yury Norov <yury.norov@...il.com>
To: Ben Horgan <ben.horgan@....com>
Cc: catalin.marinas@....com, will@...nel.org, maz@...nel.org,
	oliver.upton@...ux.dev, joey.gouly@....com, suzuki.poulose@....com,
	yuzenghui@...wei.com, linux-arm-kernel@...ts.infradead.org,
	kvmarm@...ts.linux.dev, linux@...musvillemoes.dk,
	linux-kernel@...r.kernel.org, james.morse@....com
Subject: Re: [PATCH v2 2/2] bitfield: Ensure the return values of helper
 functions are checked

On Wed, Jul 09, 2025 at 10:38:08AM +0100, Ben Horgan wrote:
> As type##_replace_bits() has no side effects it is only useful if its
> return value is checked. Add __must_check to enforce this usage. To have
> the bits replaced in-place typep##_replace_bits() can be used instead.
> 
> Although, type_##_get_bits() and type_##_encode_bits() are harder to misuse
> they are still only useful if the return value is checked. For
> consistency, also add __must_check to these.
> 
> Signed-off-by: Ben Horgan <ben.horgan@....com>

Applied.

Thanks,
Yury