linux-kernel - Re: [PATCH] iio: adc: ad7313: fix calibration channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709165819.1015259e@jic23-huawei>
Date: Wed, 9 Jul 2025 16:58:19 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Michael Hennerich 
 <Michael.Hennerich@...log.com>, Nuno Sá 
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Guillaume Ranquet
  <granquet@...libre.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7313: fix calibration channel

On Wed, 09 Jul 2025 10:33:32 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Tue, 2025-07-08 at 20:38 -0500, David Lechner wrote:
> > Fix the channel index values passed to ad_sd_calibrate() in
> > ad7173_calibrate_all().
> > 
> > ad7173_calibrate_all() expects these values to be that of the CHANNELx
> > register assigned to the channel, not the datasheet INPUTx number of the
> > channel. The incorrect values were causing register writes to fail for
> > some channels because they set the WEN bit that must always be 0 for
> > register access and set the R/W bit to read instead of write. For other
> > channels, the channel number was just wrong because the CHANNELx
> > registers are generally assigned in reverse order and so almost never
> > match the INPUTx numbers.
> > 
> > Fixes: 031bdc8aee01 ("iio: adc: ad7173: add calibration support")
> > Signed-off-by: David Lechner <dlechner@...libre.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> 
Applied to the fixes-togreg branch of iio.git.

> >  drivers/iio/adc/ad7173.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index
> > c41bc5b9ac597f57eea6a097cc3a118de7b42210..61749586670d4f0730ca423d6e4c0ee1bf19
> > edfa 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -392,13 +392,12 @@ static int ad7173_calibrate_all(struct ad7173_state *st,
> > struct iio_dev *indio_d
> >  		if (indio_dev->channels[i].type != IIO_VOLTAGE)
> >  			continue;
> >  
> > -		ret = ad_sd_calibrate(&st->sd, AD7173_MODE_CAL_INT_ZERO, st-  
> > >channels[i].ain);  
> > +		ret = ad_sd_calibrate(&st->sd, AD7173_MODE_CAL_INT_ZERO, i);
> >  		if (ret < 0)
> >  			return ret;
> >  
> >  		if (st->info->has_internal_fs_calibration) {
> > -			ret = ad_sd_calibrate(&st->sd,
> > AD7173_MODE_CAL_INT_FULL,
> > -					      st->channels[i].ain);
> > +			ret = ad_sd_calibrate(&st->sd,
> > AD7173_MODE_CAL_INT_FULL, i);
> >  			if (ret < 0)
> >  				return ret;
> >  		}
> > 
> > ---
> > base-commit: 2233378a8c606f7f6893d4c16aa6eb6fea027a52
> > change-id: 20250708-iio-adc-ad7313-fix-calibration-channel-198ed65d9b0a
> > 
> > Best regards,