[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <86ldox9voo.wl-maz@kernel.org>
Date: Wed, 09 Jul 2025 17:27:03 +0100
From: Marc Zyngier <maz@...nel.org>
To: Zenghui Yu <yuzenghui@...wei.com>
Cc: <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>,
<tglx@...utronix.de>,
<wanghaibin.wang@...wei.com>
Subject: Re: [PATCH] irqchip/gic-v3: Fix GICD_CTLR register naming
On Wed, 09 Jul 2025 14:00:46 +0100,
Zenghui Yu <yuzenghui@...wei.com> wrote:
>
> It was incorrectly named as GICD_CTRL in a pr_info() and comments. Fix
> them.
>
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
> drivers/irqchip/irq-gic-v3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index efc791c43d44..dbeb85677b08 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -190,12 +190,12 @@ static void __init gic_prio_init(void)
>
> /*
> * How priority values are used by the GIC depends on two things:
> - * the security state of the GIC (controlled by the GICD_CTRL.DS bit)
> + * the security state of the GIC (controlled by the GICD_CTLR.DS bit)
> * and if Group 0 interrupts can be delivered to Linux in the non-secure
> * world as FIQs (controlled by the SCR_EL3.FIQ bit). These affect the
> * way priorities are presented in ICC_PMR_EL1 and in the distributor:
> *
> - * GICD_CTRL.DS | SCR_EL3.FIQ | ICC_PMR_EL1 | Distributor
> + * GICD_CTLR.DS | SCR_EL3.FIQ | ICC_PMR_EL1 | Distributor
> * -------------------------------------------------------
> * 1 | - | unchanged | unchanged
> * -------------------------------------------------------
> @@ -223,7 +223,7 @@ static void __init gic_prio_init(void)
> dist_prio_nmi = __gicv3_prio_to_ns(dist_prio_nmi);
> }
>
> - pr_info("GICD_CTRL.DS=%d, SCR_EL3.FIQ=%d\n",
> + pr_info("GICD_CTLR.DS=%d, SCR_EL3.FIQ=%d\n",
> cpus_have_security_disabled,
> !cpus_have_group0);
> }
Hey, even people at ARM have made the same creative typo[1]!
Acked-by: Marc Zyngier <maz@...nel.org>
Thanks,
M.
[1] https://developer.arm.com/documentation/198123/0302/Appendix--Legacy-operation
--
Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists