linux-kernel - Re: [PATCH v2 1/2] selftests: cachestat: add tests for mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250709170403.2453228-1-joshua.hahnjy@gmail.com>
Date: Wed,  9 Jul 2025 10:03:56 -0700
From: Joshua Hahn <joshua.hahnjy@...il.com>
To: Suresh Chandrappa <suresh.k.chandrappa@...il.com>
Cc: nphamcs@...il.com,
	hannes@...xchg.org,
	shuah@...nel.org,
	linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] selftests: cachestat: add tests for mmap

On Tue, 8 Jul 2025 23:13:01 +0530 Suresh Chandrappa <suresh.k.chandrappa@...il.com> wrote:

> Hi Joshua,
> 
> Thanks for the feedback! In the first patch, both shmem and mmap operations
> are present, but I hadn’t introduced any logic to distinguish between them
> yet. That distinction is added in the second patch through a new API.

Hi Suresh,

Yes, this makes sense to me. I think what I was getting at was that we could
still make a conditional statement like

if (type == FILE_SHMEM)
	ksft_print_msg("Unable to create shmem file.\n")'
else if (type == FILE_MMAP)
	ksft_print_msg("Unable to create mmap file.\n");

(or use a switch statement)

...

And just refactor it in patch 2, as opposed to changing the behavior.
But this is mostly a nit. If you are planning to merge both patches in one
patch in the next version, then all of these comments shouldn't matter : -)

Looking forward to the next version, have a great day!
Joshua

Sent using hkml (https://github.com/sjp38/hackermail)