linux-kernel - Re: [PATCH net-next 1/5] net/mlx5e: Remove unused VLAN insertion logic in TX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709172351.GB721198@horms.kernel.org>
Date: Wed, 9 Jul 2025 18:23:51 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeed@...nel.org>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 1/5] net/mlx5e: Remove unused VLAN insertion
 logic in TX path

On Wed, Jul 09, 2025 at 12:16:23AM +0300, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> The VLAN insertion capability (`wqe_vlan_insert`) was never enabled on
> all mlx5 devices. When VLAN TX offload is advertised but this
> capability is not supported, the driver uses inline headers to insert
> the VLAN tag.
> 
> To support this, the driver used to set the
> `MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE` bit to enforce L2 inline mode
> when `wqe_vlan_insert` was not supported. Since the capability is
> disabled on all devices, this logic was always active, and the SQ flag
> has become redundant. L2 inline is enforced unconditionally for
> VLAN-tagged packets.
> 
> The `skb_vlan_tag_present()` check in the else-if block of
> `mlx5e_sq_xmit_wqe()` is never true by this point in the TX flow,
> as the VLAN tag has already been inserted by the driver using inline
> headers. As a result, this code is never executed.
> 
> Remove the redundant SQ state, dead VLAN insertion code block, and
> related logic.
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>