linux-kernel - Re: [PATCH net-next 5/5] net/mlx5e: RX, Remove unnecessary RQT redirects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709172446.GF721198@horms.kernel.org>
Date: Wed, 9 Jul 2025 18:24:46 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeed@...nel.org>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 5/5] net/mlx5e: RX, Remove unnecessary RQT
 redirects

On Wed, Jul 09, 2025 at 12:16:27AM +0300, Tariq Toukan wrote:
> RQTs (Receive Queue Table) should redirect traffic to the channels' RQs
> when they're active.  Otherwise, redirect to the designated "drop RQ".
> 
> RQTs are created in "inactive" state, pointing to the "drop RQ".
> In activate and de-activate flows, do not "deactivate" the rest of RQTs
> (beyond the num of channels), as they are already inactive.
> 
> This cuts down unnecessary execution of FW commands (MODIFY_RQT), and
> improves the latency of open/close channels or configuration change.
> 
> Perf:
> NIC: Connect-X7.
> Configuration: 1 combined channel, max num channels 248.
> Measure time for "interface up + interface down".
> 
> Before: 0.313 sec
> After:  0.057 sec (5.5x faster)
> 
> 247 MODIFY_RQT commands saved in interface up.
> 247 MODIFY_RQT commands saved in interface down.
> 
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>