lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <abbfc54d-96af-4e9d-8c2c-8965aa99076b@kernel.org>
Date: Wed, 9 Jul 2025 20:19:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jonathan Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: memory: tegra: Add Tegra264 support

On 08/07/2025 12:52, Thierry Reding wrote:
>    interrupts:
> -    items:
> -      - description: MC general interrupt
> +    minItems: 1
> +    maxItems: 8
> +
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 8
>  
>    "#address-cells":
>      const: 2
> @@ -74,6 +79,7 @@ patternProperties:
>                - nvidia,tegra186-emc
>                - nvidia,tegra194-emc
>                - nvidia,tegra234-emc
> +              - nvidia,tegra264-emc
>  
>        reg:
>          minItems: 1
> @@ -127,6 +133,15 @@ patternProperties:
>              reg:
>                minItems: 2
>  
> +      - if:
> +          properties:
> +            compatible:
> +              const: nvidia,tegra264-emc
> +        then:
> +          properties:
> +            reg:
> +              minItems: 2
> +
>      additionalProperties: false
>  
>      required:
> @@ -220,6 +235,52 @@ allOf:
>              - const: ch14
>              - const: ch15
>  
> +  - if:
> +      properties:
> +        compatible:
> +          const: nvidia,tegra264-mc
> +    then:
> +      properties:
> +        reg:
> +          minItems: 17

Missing maxItems

> +          description: 17 memory controller channels
> +
> +        reg-names:
> +          items:
> +            - const: broadcast
> +            - const: ch0
> +            - const: ch1
> +            - const: ch2
> +            - const: ch3
> +            - const: ch4
> +            - const: ch5
> +            - const: ch6
> +            - const: ch7
> +            - const: ch8
> +            - const: ch9
> +            - const: ch10
> +            - const: ch11
> +            - const: ch12
> +            - const: ch13
> +            - const: ch14
> +            - const: ch15
> +
> +        interrupts:
> +          minItems: 8
> +          maxItems: 8
> +          description: One interrupt line for each MC component
> +
> +        interrupt-names:
> +          items:
> +            - const: mcf
> +            - const: hub1
> +            - const: hub2
> +            - const: hub3
> +            - const: hub4
> +            - const: hub5
> +            - const: sbs
> +            - const: channel


Missing constraints for interrupts and interrupt-names for all other
variants. Now this patch claims they all have 8 interrupts with any name.



Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ