linux-kernel - Re: [PATCH v8 14/29] iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG67GDY97U8T6kuD@Asurada-Nvidia>
Date: Wed, 9 Jul 2025 11:55:20 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <corbet@....net>, <will@...nel.org>,
	<bagasdotme@...il.com>, <robin.murphy@....com>, <joro@...tes.org>,
	<thierry.reding@...il.com>, <vdumpa@...dia.com>, <jonathanh@...dia.com>,
	<shuah@...nel.org>, <jsnitsel@...hat.com>, <nathan@...nel.org>,
	<peterz@...radead.org>, <yi.l.liu@...el.com>, <mshavit@...gle.com>,
	<praan@...gle.com>, <zhangzekun11@...wei.com>, <iommu@...ts.linux.dev>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-tegra@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <patches@...ts.linux.dev>,
	<mochs@...dia.com>, <alok.a.tiwari@...cle.com>, <vasant.hegde@....com>,
	<dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v8 14/29] iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC
 ioctl

On Wed, Jul 09, 2025 at 02:09:04PM -0300, Jason Gunthorpe wrote:
> On Fri, Jul 04, 2025 at 06:13:30PM -0700, Nicolin Chen wrote:
> > +static struct iommufd_access *
> > +iommufd_hw_queue_alloc_phys(struct iommu_hw_queue_alloc *cmd,
> > +			    struct iommufd_viommu *viommu, phys_addr_t *base_pa)
> > +{
> > +	struct iommufd_access *access;
> > +	struct page **pages;
> > +	size_t max_npages;
> > +	size_t length;
> > +	u64 offset;
> > +	size_t i;
> > +	int rc;
> > +
> > +	offset =
> > +		cmd->nesting_parent_iova - PAGE_ALIGN(cmd->nesting_parent_iova);
> 
> PAGE_ALIGN is ALIGN UP, that is the wrong direction?
> 
> It is just:
> 
>       offset = cmd->nesting_parent_iova % PAGE_SIZE;
> 
> And this is missing:
> 
> 	*base_pa = (page_to_pfn(pages[0]) << PAGE_SHIFT) + offset;
> 
> ??

Yes, my bad. And I realized that all my testings are page aligned.
Maybe we could add an IOMMU_TEST_OP_HW_QUEUE_CHECK_ADDR..

Thanks
Nicolin