| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250709193704.r7p6wkst3ydvdtqx@antoni-VivoBook-ASUSLaptop-X512FAY-K512FA>
Date: Wed, 9 Jul 2025 21:37:04 +0200
From: Antoni Pokusinski <apokusinski01@...il.com>
To: alexandre.belloni@...tlin.com
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org,
alexander.stein@...tq-group.com, linux-rtc@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH RESEND v4 3/3] rtc: pcf85063: add support for RV8063
Hello,
Since there was no feedback for this patch I'd like to send a reminder here.
Is there a chance that this patch series will get integrated into the mainline?
Kind regards,
Antoni Pokusinski
On Fri, May 09, 2025 at 08:37:50PM +0200, Antoni Pokusinski wrote:
> Microcrystal RV8063 is a real-time clock with SPI interface. Its
> functionality is very similar to the RV8263 rtc.
>
> Signed-off-by: Antoni Pokusinski <apokusinski01@...il.com>
> ---
> drivers/rtc/Kconfig | 21 +++++----
> drivers/rtc/rtc-pcf85063.c | 87 +++++++++++++++++++++++++++++++++++++-
> 2 files changed, 98 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 838bdc138ffe..1b9be96faa13 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -483,15 +483,6 @@ config RTC_DRV_PCF8523
> This driver can also be built as a module. If so, the module
> will be called rtc-pcf8523.
>
> -config RTC_DRV_PCF85063
> - tristate "NXP PCF85063"
> - select REGMAP_I2C
> - help
> - If you say yes here you get support for the PCF85063 RTC chip
> -
> - This driver can also be built as a module. If so, the module
> - will be called rtc-pcf85063.
> -
> config RTC_DRV_PCF85363
> tristate "NXP PCF85363"
> select REGMAP_I2C
> @@ -971,6 +962,18 @@ config RTC_DRV_PCF2127
> This driver can also be built as a module. If so, the module
> will be called rtc-pcf2127.
>
> +config RTC_DRV_PCF85063
> + tristate "NXP PCF85063"
> + depends on RTC_I2C_AND_SPI
> + select REGMAP_I2C if I2C
> + select REGMAP_SPI if SPI_MASTER
> + help
> + If you say yes here you get support for the PCF85063 and RV8063
> + RTC chips.
> +
> + This driver can also be built as a module. If so, the module
> + will be called rtc-pcf85063.
> +
> config RTC_DRV_RV3029C2
> tristate "Micro Crystal RV3029/3049"
> depends on RTC_I2C_AND_SPI
> diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
> index 03dfc58f4cd7..d9b67b959d18 100644
> --- a/drivers/rtc/rtc-pcf85063.c
> +++ b/drivers/rtc/rtc-pcf85063.c
> @@ -17,6 +17,7 @@
> #include <linux/of.h>
> #include <linux/pm_wakeirq.h>
> #include <linux/regmap.h>
> +#include <linux/spi/spi.h>
>
> /*
> * Information for this driver was pulled from the following datasheets.
> @@ -29,6 +30,9 @@
> *
> * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/RV-8263-C7_App-Manual.pdf
> * RV8263 -- Rev. 1.0 — January 2019
> + *
> + * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/RV-8063-C7_App-Manual.pdf
> + * RV8063 -- Rev. 1.1 - October 2018
> */
>
> #define PCF85063_REG_CTRL1 0x00 /* status */
> @@ -559,6 +563,18 @@ static const struct pcf85063_config config_rv8263 = {
> .force_cap_7000 = 1,
> };
>
> +static const struct pcf85063_config config_rv8063 = {
> + .regmap = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = 0x11,
> + .read_flag_mask = BIT(7) | BIT(5),
> + .write_flag_mask = BIT(5),
> + },
> + .has_alarms = 1,
> + .force_cap_7000 = 1,
> +};
> +
> static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
> const struct pcf85063_config *config)
> {
> @@ -725,14 +741,83 @@ static void pcf85063_unregister_driver(void)
>
> #endif /* IS_ENABLED(CONFIG_I2C) */
>
> +#if IS_ENABLED(CONFIG_SPI_MASTER)
> +
> +static const struct spi_device_id rv8063_id[] = {
> + { "rv8063" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(spi, rv8063_id);
> +
> +static const struct of_device_id rv8063_of_match[] = {
> + { .compatible = "microcrystal,rv8063" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, rv8063_of_match);
> +
> +static int rv8063_probe(struct spi_device *spi)
> +{
> + const struct pcf85063_config *config = &config_rv8063;
> + struct regmap *regmap;
> +
> + regmap = devm_regmap_init_spi(spi, &config->regmap);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + return pcf85063_probe(&spi->dev, regmap, spi->irq, config);
> +}
> +
> +static struct spi_driver rv8063_driver = {
> + .driver = {
> + .name = "rv8063",
> + .of_match_table = rv8063_of_match,
> + },
> + .probe = rv8063_probe,
> + .id_table = rv8063_id,
> +};
> +
> +static int __init rv8063_register_driver(void)
> +{
> + return spi_register_driver(&rv8063_driver);
> +}
> +
> +static void __exit rv8063_unregister_driver(void)
> +{
> + spi_unregister_driver(&rv8063_driver);
> +}
> +
> +#else
> +
> +static int __init rv8063_register_driver(void)
> +{
> + return 0;
> +}
> +
> +static void __exit rv8063_unregister_driver(void)
> +{
> +}
> +
> +#endif /* IS_ENABLED(CONFIG_SPI_MASTER) */
> +
> static int __init pcf85063_init(void)
> {
> - return pcf85063_register_driver();
> + int ret;
> +
> + ret = pcf85063_register_driver();
> + if (ret)
> + return ret;
> +
> + ret = rv8063_register_driver();
> + if (ret)
> + pcf85063_unregister_driver();
> +
> + return ret;
> }
> module_init(pcf85063_init);
>
> static void __exit pcf85063_exit(void)
> {
> + rv8063_unregister_driver();
> pcf85063_unregister_driver();
> }
> module_exit(pcf85063_exit);
> --
> 2.25.1
>
Powered by blists - more mailing lists