linux-kernel - Re: linux-next: build failure after merge of the vhost tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250709165533-mutt-send-email-mst@kernel.org>
Date: Wed, 9 Jul 2025 16:55:43 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the vhost tree

On Wed, Jul 09, 2025 at 01:51:53PM -0700, Randy Dunlap wrote:
> 
> 
> On 7/9/25 1:00 PM, Michael S. Tsirkin wrote:
> > On Wed, Jul 09, 2025 at 10:19:05PM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the vhost tree, today's linux-next build (x86_64
> >> allnoconfig) failed like this:
> >>
> >> In file included from /home/sfr/next/next/arch/x86/events/amd/ibs.c:12:
> >> /home/sfr/next/next/include/linux/pci.h: In function 'pci_set_disconnect_work':
> >> /home/sfr/next/next/include/linux/pci.h:2738:14: error: implicit declaration of function 'pci_device_is_present'; did you mean 'pci_dev_present'? [-Wimplicit-function-declaration]
> >>  2738 |         if (!pci_device_is_present(pdev))
> >>       |              ^~~~~~~~~~~~~~~~~~~~~
> >>       |              pci_dev_present
> >>
> >> Caused by commit
> >>
> >>   b7468115b604 ("pci: report surprise removal event")
> >>
> >> I have reverted that commit and the 4 following ones (just in case).
> >>
> >> -- 
> >> Cheers,
> >> Stephen Rothwell
> > 
> > 
> > 
> > Weird:
> > $ git grep pci_device_is_present include/linux/pci.h 
> > include/linux/pci.h:bool pci_device_is_present(struct pci_dev *pdev);
> > include/linux/pci.h:    if (!pci_device_is_present(pdev))
> > 
> 
> in x86_64 allnoconfig, CONFIG_PCI is not enabled.
> 
> The function is only defined when CONFIG_PCI is enabled.
> 
> 
> > and of course I did build it ... which commit should I test?
> > 
> 
> The one that Stephen listed above?
> 
> -- 
> ~Randy

Fixed now, thanks!