linux-kernel - Re: [PATCH V3 3/3] ufs: ufs-qcom: Enable QUnipro Internal Clock Gating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4654034-a94b-473b-907a-2687acf11af4@quicinc.com>
Date: Thu, 10 Jul 2025 02:43:47 +0530
From: Nitin Rawat <quic_nitirawa@...cinc.com>
To: Avri Altman <Avri.Altman@...disk.com>,
        "mani@...nel.org"
	<mani@...nel.org>,
        "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>,
        "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "avri.altman@....com" <avri.altman@....com>,
        "ebiggers@...gle.com"
	<ebiggers@...gle.com>,
        "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>,
        "konrad.dybcio@....qualcomm.com"
	<konrad.dybcio@....qualcomm.com>
CC: "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH V3 3/3] ufs: ufs-qcom: Enable QUnipro Internal Clock
 Gating



On 7/9/2025 10:46 AM, Avri Altman wrote:
>> Enable internal clock gating for QUnipro by setting the following attributes to 1
>> during host controller initialization:
>> - DL_VS_CLK_CFG
>> - PA_VS_CLK_CFG_REG
>> - DME_VS_CORE_CLK_CTRL.DME_HW_CGC_EN
>>
>> This change is necessary to support the internal clock gating mechanism in
>> Qualcomm UFS host controller. This is power saving feature and hence driver
>> can continue to function correctly despite any error in enabling these feature.
> Does this change offloads clock gating?
> i.e. no need to set UFSHCD_CAP_CLK_GATING ?
No , this change does not offload sw based UFS clock gating. Host 
controller has its own internal clock gating mechanism.
> 
> Thanks,
> Avri