linux-kernel - Re: [PATCH v2 07/12] pinctrl: ingenic: use pinmux_generic_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a2c7d244d0467d7236dbce920319c6df519bad7.camel@crapouillou.net>
Date: Wed, 09 Jul 2025 23:25:30 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij	
 <linus.walleij@...aro.org>, Bjorn Andersson <andersson@...nel.org>, Konrad
 Dybcio <konradybcio@...nel.org>, Alexey Klimov <alexey.klimov@...aro.org>,
 Lorenzo Bianconi	 <lorenzo@...nel.org>, Sean Wang <sean.wang@...nel.org>,
 Matthias Brugger	 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org, Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 07/12] pinctrl: ingenic: use
 pinmux_generic_add_pinfunction()

Hi Bartosz,

Le mercredi 09 juillet 2025 à 16:39 +0200, Bartosz Golaszewski a
écrit :
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Instead of passing individual fields of struct pinfunction to
> pinmux_generic_add_function(), use pinmux_generic_add_pinfunction()
> and
> pass the entire structure directly.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index
> 3c660471ec6911ee494f45d2ffc13c4dc496fd2e..79119cf20efcf8cc701647d9ff9
> 79c2b71bf7589 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -4574,9 +4574,8 @@ static int __init ingenic_pinctrl_probe(struct
> platform_device *pdev)
>  		const struct function_desc *function = &chip_info-
> >functions[i];
>  		const struct pinfunction *func = &function->func;
>  
> -		err = pinmux_generic_add_function(jzpc->pctl, func-
> >name,
> -						  func->groups,
> func->ngroups,
> -						  function->data);
> +		err = pinmux_generic_add_pinfunction(jzpc->pctl,
> func,
> +						     function-
> >data);
>  		if (err < 0) {
>  			dev_err(dev, "Failed to register function
> %s\n", func->name);
>  			return err;