linux-kernel - Re: [PATCH] net: pse-pd: pd692x0: reduce stack usage in pd692x0_setup_pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250710000750.5c0d651f@kmaincent-XPS-13-7390>
Date: Thu, 10 Jul 2025 00:07:50 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>, Colin Ian King
 <colin.i.king@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pse-pd: pd692x0: reduce stack usage in
 pd692x0_setup_pi_matrix

Le Wed,  9 Jul 2025 17:32:04 +0200,
Arnd Bergmann <arnd@...nel.org> a écrit :

> From: Arnd Bergmann <arnd@...db.de>
> 
> The pd692x0_manager array in this function is really too big to fit on the
> stack, though this never triggered a warning until a recent patch made
> it slightly bigger:
> 
> drivers/net/pse-pd/pd692x0.c: In function 'pd692x0_setup_pi_matrix':
> drivers/net/pse-pd/pd692x0.c:1210:1: error: the frame size of 1584 bytes is
> larger than 1536 bytes [-Werror=frame-larger-than=]
> 
> Change the function to dynamically allocate the array here.

Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com