linux-kernel - Re: [PATCH] wifi: rtw88: enable TX reports for the management queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG7rSzyOWqIWMSII@skv.local>
Date: Thu, 10 Jul 2025 01:20:59 +0300
From: Andrey Skvortsov <andrej.skvortzov@...il.com>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Kalle Valo <kvalo@...nel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bitterblue Smith <rtl8821cerfe2@...il.com>,
	Fiona Klute <fiona.klute@....de>
Subject: Re: [PATCH] wifi: rtw88: enable TX reports for the management queue

On 25-06-30 01:51, Ping-Ke Shih wrote:
> Andrey Skvortsov <andrej.skvortzov@...il.com> wrote:
> > This is needed for AP mode. Otherwise client sees the network, but
> > can't connect to it.
> > 
> > REG_FWHW_TXQ_CTRL+1 is set to WLAN_TXQ_RPT_EN (0x1F) in common mac
> > init function (__rtw8723x_mac_init), but the value was overwritten
> > from mac table later.
> 
> Since the tables were copied from vendor driver, I suspect people might
> overwrite the tables again resulting in regression. 
> 
> So we can add a mac_post_init to set the value after loading parameters:
> 
>   rtw_mac_init(rtwdev); // not set REG_FWHW_TXQ_CTRL+1 to WLAN_TXQ_RPT_EN
> 
>   chip->ops->phy_set_param(rtwdev); // "0x421, 0x0000000F," by table
> 
>   rtw_mac_postinit(rtwdev); // set REG_FWHW_TXQ_CTRL+1 to WLAN_TXQ_RPT_EN 
> 
> Only rtw8703b/rtw8723d implement postinit ops.
> 

Thanks for the feedback, I'll add this in v2.

-- 
Best regards,
Andrey Skvortsov