linux-kernel - Re: [PATCH] Drivers: hv: Fix the check for HYPERVISOR_CALLBACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG76RTo4aleKdqbi@liuwe-devbox-ubuntu-v2.lamzopl0uupeniq2etz1fddiyg.xx.internal.cloudapp.net>
Date: Wed, 9 Jul 2025 23:24:53 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Roman Kisel <romank@...ux.microsoft.com>
Cc: Naman Jain <namjain@...ux.microsoft.com>, linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	namjain@...rosoft.com, "K . Y . Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Michael Kelley <mhklinux@...look.com>
Subject: Re: [PATCH] Drivers: hv: Fix the check for HYPERVISOR_CALLBACK_VECTOR

On Mon, Jul 07, 2025 at 10:58:03AM -0700, Roman Kisel wrote:
> 
> 
> On 7/7/2025 1:43 AM, Naman Jain wrote:
> > __is_defined(HYPERVISOR_CALLBACK_VECTOR) would return 1, only if
> > HYPERVISOR_CALLBACK_VECTOR macro is defined as 1. However its value is
> > 0xf3 and this leads to __is_defined() returning 0. The expectation
> > was to just check whether this MACRO is defined or not and get 1 if
> > it's defined. Replace __is_defined with #ifdef blocks instead to
> > fix it.
> > 
> > Fixes: 1dc5df133b98 ("Drivers: hv: vmbus: Get the IRQ number from DeviceTree")
> > Cc: stable@...nel.org
> > Signed-off-by: Naman Jain <namjain@...ux.microsoft.com>
> > ---
> 
> [...]
> 
> Appreciate fixing that! From what I learned from you, x86 was broken.
> Very likely I did a smoke test there only while focusing on arm64. Sorry
> about that, thanks again!!
> 
> LGTM.
> Reviewed-by: Roman Kisel <romank@...ux.microsoft.com
> 

Applied to hyperv-fixes. Thanks!