linux-kernel - Re: [PATCH] riscv: mmap(): use unsigned offset type in riscv_sys_mmap

Open Source and information security mailing list archives

Message-Id: <EDA763D9-2FA6-4F0F-9855-01D59E340A52@gmail.com>
Date: Wed, 9 Jul 2025 13:28:18 +0800
From: "Han Gao (Revy)" <rabenda.cn@...il.com>
To: liu.xuemei1@....com.cn
Cc: paul.walmsley@...ive.com,
 palmer@...belt.com,
 aou@...s.berkeley.edu,
 alex@...ti.fr,
 linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: mmap(): use unsigned offset type in riscv_sys_mmap


> On Jul 7, 2025, at 19:34, liu.xuemei1@....com.cn wrote:
> 
> From: Jessica Liu <liu.xuemei1@....com.cn>
> 
> The variable type of offset should be consistent with the relevant
> interfaces of mmap which described in commit 295f10061af0 ("syscalls:
> mmap(): use unsigned offset type consistently). Otherwise, a user input
> with the top bit set would result in a negative page offset rather than a
> large one.
> 
> Signed-off-by: Jessica Liu <liu.xuemei1@....com.cn>
Tested-by: Han Gao <rabenda.cn@...il.com>
> ---
> arch/riscv/kernel/sys_riscv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index d77afe05578f..795b2e815ac9 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -10,7 +10,7 @@
> 
> static long riscv_sys_mmap(unsigned long addr, unsigned long len,
> 			   unsigned long prot, unsigned long flags,
> -			   unsigned long fd, off_t offset,
> +			   unsigned long fd, unsigned long offset,
> 			   unsigned long page_shift_offset)
> {
> 	if (unlikely(offset & (~PAGE_MASK >> page_shift_offset)))
> -- 
> 2.25.1
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives