linux-kernel - Re: [PATCH 10/12] wifi: mwifiex: Use max() to improve code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG4BUWM8o8S7bR9p@nxpwireless-Inspiron-14-Plus-7440>
Date: Wed, 9 Jul 2025 13:42:41 +0800
From: Jeff Chen <jeff.chen_1@....com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Johannes Berg <johannes.berg@...el.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Kalle Valo <kvalo@...nel.org>, David Lin <yu-hao.lin@....com>,
	Aditya Kumar Singh <quic_adisi@...cinc.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	"open list:MARVELL MWIFIEX WIRELESS DRIVER" <linux-wireless@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/12] wifi: mwifiex: Use max() to improve code

Hi Qianfeng,
Thanks for the cleanup.

On Wed, Jul 09, 2025 at 10:21:38 AM +0800, Qianfeng Rong wrote:
> Use max() to reduce the code and improve its readability.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 286378770e9e..d81db73ac77f 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4783,10 +4783,8 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
>  		wiphy->iface_combinations = &mwifiex_iface_comb_ap_sta;
>  	wiphy->n_iface_combinations = 1;
>  
> -	if (adapter->max_sta_conn > adapter->max_p2p_conn)
> -		wiphy->max_ap_assoc_sta = adapter->max_sta_conn;
> -	else
> -		wiphy->max_ap_assoc_sta = adapter->max_p2p_conn;
> +	wiphy->max_ap_assoc_sta = max(adapter->max_sta_conn,
> +				      adapter->max_p2p_conn);

adapter->max_sta_conn and adapter->max_p2p_conn are u8, and wiphy->max_ap_assoc_sta is u16.
To ensure type safety and maintainability, I recommend using max_t() with typeof():
wiphy->max_ap_assoc_sta = max_t(typeof(wiphy->max_ap_assoc_sta),
                                adapter->max_sta_conn,
                                adapter->max_p2p_conn);

>  
>  	/* Initialize cipher suits */
>  	wiphy->cipher_suites = mwifiex_cipher_suites;
> -- 
> 2.34.1
>