linux-kernel - 回覆: [net-next v3 1/4] dt-bindings: net: ftgmac100: Add resets property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51349252F19C2742CA1E369C9D49A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 9 Jul 2025 05:52:12 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
	<joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "horms@...nel.org"
	<horms@...nel.org>, "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>, BMC-SW <BMC-SW@...eedtech.com>
Subject:
 回覆: [net-next v3 1/4] dt-bindings: net: ftgmac100: Add resets property

Hi Krzysztof

Thank you for your reply.

> > Add optional resets property for Aspeed SoCs to reset the MAC and
> 
> s/Aspeed SoCs/Aspeed AST2600 SoCs/
> 
> > RGMII/RMII.
> 
> ... because ? It was missing? Incomplete? You changed hardware?
> 
> Make the commits useful, explain WHY you are doing, not repeating WHAT
> you are doing. What is obvious from the diff. You already got this feedback with
> other patches.
> 

Agreed.
Got it. I will add more commit message to describe why we do that and
what we do.

> >
> > Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
> > ---
> >  .../bindings/net/faraday,ftgmac100.yaml       | 23
> ++++++++++++++++---
> >  1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > index 55d6a8379025..a2e7d439074a 100644
> > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -6,9 +6,6 @@ $schema:
> http://devicetree.org/meta-schemas/core.yaml#
> >
> >  title: Faraday Technology FTGMAC100 gigabit ethernet controller
> >
> > -allOf:
> > -  - $ref: ethernet-controller.yaml#
> > -
> >  maintainers:
> >    - Po-Yu Chuang <ratbert@...aday-tech.com>
> >
> > @@ -35,6 +32,11 @@ properties:
> >        - description: MAC IP clock
> >        - description: RMII RCLK gate for AST2500/2600
> >
> > +  resets:
> > +    maxItems: 1
> > +    description:
> > +      Optional reset control for the MAC controller
> 
> Drop description, redundant and obvious form the schema. It cannot be a reset
> for anything else than MAC controller, because this is the MAC controller. It
> cannot be "non optional" because schema says it is optional.
> 
> Write concise and USEFUL descriptions/commit messages, not just something
> to satisfy line/patch count.

Agreed.
I will adjust this part to meet schema.

Thanks,
Jacky