linux-kernel - Re: [PATCH net-next v7 01/15] dt-bindings: net: Introduce the ethernet-connector description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709083629.51c95507@fedora>
Date: Wed, 9 Jul 2025 08:36:29 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Rob Herring <robh@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>, Jakub Kicinski
 <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, Christophe Leroy
 <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>,
 Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit
 <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>, Marek
 Behún <kabel@...nel.org>, Oleksij Rempel
 <o.rempel@...gutronix.de>, Nicolò Veronese
 <nicveronese@...il.com>, Simon Horman <horms@...nel.org>,
 mwojtas@...omium.org, Antoine Tenart <atenart@...nel.org>,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Romain Gantois
 <romain.gantois@...tlin.com>, Daniel Golle <daniel@...rotopia.org>, Dimitri
 Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v7 01/15] dt-bindings: net: Introduce the
 ethernet-connector description

Hi Rob,

On Tue, 8 Jul 2025 10:57:33 -0500
Rob Herring <robh@...nel.org> wrote:

> On Mon, Jun 30, 2025 at 04:33:00PM +0200, Maxime Chevallier wrote:
> > The ability to describe the physical ports of Ethernet devices is useful
> > to describe multi-port devices, as well as to remove any ambiguity with
> > regard to the nature of the port.
> > 
> > Moreover, describing ports allows for a better description of features
> > that are tied to connectors, such as PoE through the PSE-PD devices.
> > 
> > Introduce a binding to allow describing the ports, for now with 2
> > attributes :
> > 
> >  - The number of lanes, which is a quite generic property that allows
> >    differentating between multiple similar technologies such as BaseT1
> >    and "regular" BaseT (which usually means BaseT4).
> > 
> >  - The media that can be used on that port, such as BaseT for Twisted
> >    Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane
> >    ethernet, etc. This allows defining the nature of the port, and
> >    therefore avoids the need for vendor-specific properties such as
> >    "micrel,fiber-mode" or "ti,fiber-mode".
> > 
> > The port description lives in its own file, as it is intended in the
> > future to allow describing the ports for phy-less devices.
> > 
> > Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > ---
> >  .../bindings/net/ethernet-connector.yaml      | 47 +++++++++++++++++++
> >  .../devicetree/bindings/net/ethernet-phy.yaml | 18 +++++++
> >  MAINTAINERS                                   |  1 +
> >  3 files changed, 66 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/ethernet-connector.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ethernet-connector.yaml b/Documentation/devicetree/bindings/net/ethernet-connector.yaml
> > new file mode 100644
> > index 000000000000..2aa28e6c1523
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ethernet-connector.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/ethernet-connector.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Generic Ethernet Connector
> > +
> > +maintainers:
> > +  - Maxime Chevallier <maxime.chevallier@...tlin.com>
> > +
> > +description:
> > +  An Ethernet Connectr represents the output of a network component such as  
> 
> typo
> 
> > +  a PHY, an Ethernet controller with no PHY, or an SFP module.
> > +
> > +properties:
> > +
> > +  lanes:
> > +    description:
> > +      Defines the number of lanes on the port, that is the number of physical
> > +      channels used to convey the data with the link partner.
> > +    $ref: /schemas/types.yaml#/definitions/uint32  
> 
> maximum?
> 
> Or I'd guess this is power of 2 values?

All values that exist so far are indeed power of 2 values, but that's
not a strict requirement, there may be other values one day. I'll add
all possible values (1, 2 , 4 , 8) so far.
> 
> > +
> > +  media:
> > +    description:
> > +      The mediums, as defined in 802.3, that can be used on the port.
> > +    items:
> > +      enum:
> > +        - BaseT
> > +        - BaseK
> > +        - BaseS
> > +        - BaseC
> > +        - BaseL
> > +        - BaseD
> > +        - BaseE
> > +        - BaseF
> > +        - BaseV
> > +        - BaseMLD
> > +        - BaseX  

Heh I need to remove BaseX

> 
> This can be multiple values? But then how does one know what is actually 
> attached?

I don't see a scenario where we would put multiple values actually. I
need to update the code accordingly, but if we are in the case where we
need to specify in DT which medium we use, then that means we can only
use one.

Thanks you for reviewing,

Maxime