linux-kernel - Re: [PATCH 59/80] slimbus: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fc97dc4-fe5a-4f4c-bd43-df89c7dbc178@kernel.org>
Date: Wed, 9 Jul 2025 07:41:41 +0100
From: Srinivas Kandagatla <srini@...nel.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Srinivas Kandagatla <srini@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 59/80] slimbus: Remove redundant
 pm_runtime_mark_last_busy() calls



On 7/4/25 8:54 AM, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---

Acked-by: Srinivas Kandagatla <srini@...nel.org>

--srini

> The cover letter of the set can be found here
> <URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ailus@linux.intel.com>.
> 
> In brief, this patch depends on PM runtime patches adding marking the last
> busy timestamp in autosuspend related functions. The patches are here, on
> rc2:
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
>                 pm-runtime-6.17-rc1
> 
>  drivers/slimbus/core.c      | 1 -
>  drivers/slimbus/messaging.c | 2 --
>  drivers/slimbus/qcom-ctrl.c | 1 -
>  3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 005fa2ef100f..31751ee4e400 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -504,7 +504,6 @@ int slim_device_report_present(struct slim_controller *ctrl,
>  	ret = slim_device_alloc_laddr(sbdev, true);
>  
>  slimbus_not_active:
> -	pm_runtime_mark_last_busy(ctrl->dev);
>  	pm_runtime_put_autosuspend(ctrl->dev);
>  	return ret;
>  }
> diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
> index 6f01d944f9c6..44197493010e 100644
> --- a/drivers/slimbus/messaging.c
> +++ b/drivers/slimbus/messaging.c
> @@ -47,7 +47,6 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len)
>  		complete(txn->comp);
>  
>  	/* Remove runtime-pm vote now that response was received for TID txn */
> -	pm_runtime_mark_last_busy(ctrl->dev);
>  	pm_runtime_put_autosuspend(ctrl->dev);
>  }
>  EXPORT_SYMBOL_GPL(slim_msg_response);
> @@ -171,7 +170,6 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn)
>  		 * remove runtime-pm vote if this was TX only, or
>  		 * if there was error during this transaction
>  		 */
> -		pm_runtime_mark_last_busy(ctrl->dev);
>  		pm_runtime_put_autosuspend(ctrl->dev);
>  	}
>  	return ret;
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index ab344f7472f2..880cf3081a20 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -695,7 +695,6 @@ static int qcom_slim_resume(struct device *dev)
>  		dev_dbg(dev, "system resume");
>  		ret = qcom_slim_runtime_resume(dev);
>  		if (!ret) {
> -			pm_runtime_mark_last_busy(dev);
>  			pm_request_autosuspend(dev);
>  		}
>  		return ret;