linux-kernel - Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <738c1951-afbc-4cda-a16e-54a5055ca7c8@kernel.org>
Date: Wed, 9 Jul 2025 08:57:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hailong Fan (范海龙) <Hailong.Fan@...iatek.com>,
 "perex@...ex.cz" <perex@...ex.cz>,
 "pierre-louis.bossart@...ux.dev" <pierre-louis.bossart@...ux.dev>,
 "kai.vehmanen@...ux.intel.com" <kai.vehmanen@...ux.intel.com>,
 "broonie@...nel.org" <broonie@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>, "tiwai@...e.com"
 <tiwai@...e.com>, "robh@...nel.org" <robh@...nel.org>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>,
 "yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "peter.ujfalusi@...ux.intel.com" <peter.ujfalusi@...ux.intel.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "daniel.baluta@....com" <daniel.baluta@....com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "ranjani.sridharan@...ux.intel.com" <ranjani.sridharan@...ux.intel.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "sound-open-firmware@...a-project.org"
 <sound-open-firmware@...a-project.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp
 document

On 09/07/2025 08:05, Hailong Fan (范海龙) wrote:
>>
>> OK, this is a valid argument, however we still try to unify the
>> inputs
>> so bindings can share such pieces. It is discouraged to have similar
>> devices with different bindings in only one place: clk26m -> clk27m
>> or
>> whatever other number.
>>
>> Common is also to name the clock input based on the purpose (like
>> bus, ref).
>>
>>
>> Best regards,
>> Krzysztof
> 
> On the MediaTek platform, the main SoC clock sources are typically 32K,
> 13M, and 26M. This is why the terms clk32k, clk13m, and clk26m are
> used.
> Specifically, clk26m refers to the system’s 26 MHz clock source.
> The clkxxx naming convention is intended to indicate that these are SoC

But it should nnot.

> clock sources, while also distinguishing between different clock
> frequencies.
>  
> Therefore, using other terms could potentially cause confusion.

No, you don't understand. This device receives some main PLL or ref
clock. That's the only important information in the name, not its
frequency..

>  
> For example, the ADSP clock sources are ADSPPLL(800MHz) and
> clk26m(26MHz).
> On other platforms, the definition of clk26m in the Device Tree Source
> (DTS) is as follows:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8188.dtsi#n328
> The mt8196 platform uses the same design.

So you add poor code, because previously Mediatek added more poor code?
What sort of argument is that?


Best regards,
Krzysztof