linux-kernel - RE: [PATCH] firmware: arm_scmi: convert to SYSTEM_SLEEP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845996327A0D0D85A1A93E8F8849A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 9 Jul 2025 07:04:49 +0000
From: Peng Fan <peng.fan@....com>
To: Arnd Bergmann <arnd@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
	Nathan Chancellor <nathan@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Cristian Marussi
	<cristian.marussi@....com>, "arm-scmi@...r.kernel.org"
	<arm-scmi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] firmware: arm_scmi: convert to SYSTEM_SLEEP_PM_OPS

> Subject: [PATCH] firmware: arm_scmi: convert to
> SYSTEM_SLEEP_PM_OPS
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The old SET_SYSTEM_SLEEP_PM_OPS() macro leads to a warning about
> an unused function:
> 
> drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error:
> 'scmi_system_power_resume' defined but not used [-Werror=unused-
> function]
>   363 | static int scmi_system_power_resume(struct device *dev)
> 
> The proper way to do this these days is to use
> SYSTEM_SLEEP_PM_OPS() and pm_sleep_ptr().
> 
> Fixes: 9a0658d3991e ("firmware: arm_scmi: power_control: Ensure
> SCMI_SYSPOWER_IDLE is set early during resume")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix. Nathan Chancellor posted a fix earlier, but
yours has pm_sleep_ptr which is better.

Acked-by: Peng Fan <peng.fan@....com>