linux-kernel - Re: [PATCH] crypto: acomp - Fix CFI failure due to type punning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG4Xwjups+9zr+Sl@gcabiddu-mobl.ger.corp.intel.com>
Date: Wed, 9 Jul 2025 08:18:26 +0100
From: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To: Eric Biggers <ebiggers@...nel.org>
CC: <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Suman
 Kumar Chakraborty" <suman.kumar.chakraborty@...el.com>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] crypto: acomp - Fix CFI failure due to type punning

On Tue, Jul 08, 2025 at 05:59:54PM -0700, Eric Biggers wrote:
> To avoid a crash when control flow integrity is enabled, make the
> workspace ("stream") free function use a consistent type, and call it
> through a function pointer that has that same type.
> 
> Fixes: 42d9f6c77479 ("crypto: acomp - Move scomp stream allocation code into acomp")
> Cc: stable@...r.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  crypto/deflate.c                    | 7 ++++++-
>  crypto/zstd.c                       | 7 ++++++-
>  include/crypto/internal/acompress.h | 5 +----
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 

Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

Regards,

-- 
Giovanni