linux-kernel - Re: [RFC PATCH RESEND] tracing: add kernel documentation for trace_array_set_clr_event, trace_set_clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250709100626.fc0611eb6801b7a8dad9164f@kernel.org>
Date: Wed, 9 Jul 2025 10:06:26 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Gabriele Paoloni <gpaoloni@...hat.com>, mhiramat@...nel.org,
 mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [RFC PATCH RESEND] tracing: add kernel documentation for
 trace_array_set_clr_event, trace_set_clr_event and supporting functions

On Tue, 1 Jul 2025 19:59:39 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> > + * __ftrace_event_enable_disable - enable or disable a trace event
> > + * @file: trace event file associated with the event.
> > + * @enable: 0 or 1 respectively to disable/enable the event (any other value is
> > + * invalid).
> 
> Saying 0 or 1 should assume that those are the only values. Don't need the
> content in the parenthesis.

BTW, it should be "0 or !0"? (or we should make it boolean)
This description means if it is "2", that is undefined.

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>