linux-kernel - Re: [PATCH bpf-next v3 5/7] bpf: Remove attach_type in bpf_netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874ivlg4fq.fsf@cloudflare.com>
Date: Wed, 09 Jul 2025 10:21:29 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: Tao Chen <chen.dylane@...ux.dev>
Cc: daniel@...earbox.net,  razor@...ckwall.org,  andrew+netdev@...n.ch,
  davem@...emloft.net,  edumazet@...gle.com,  kuba@...nel.org,
  pabeni@...hat.com,  ast@...nel.org,  andrii@...nel.org,
  martin.lau@...ux.dev,  eddyz87@...il.com,  song@...nel.org,
  yonghong.song@...ux.dev,  john.fastabend@...il.com,  kpsingh@...nel.org,
  sdf@...ichev.me,  haoluo@...gle.com,  jolsa@...nel.org,
  mattbobrowski@...gle.com,  rostedt@...dmis.org,  mhiramat@...nel.org,
  mathieu.desnoyers@...icios.com,  horms@...nel.org,  willemb@...gle.com,
  pablo@...filter.org,  kadlec@...filter.org,  hawk@...nel.org,
  bpf@...r.kernel.org,  netdev@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-trace-kernel@...r.kernel.org,
  netfilter-devel@...r.kernel.org,  coreteam@...filter.org
Subject: Re: [PATCH bpf-next v3 5/7] bpf: Remove attach_type in bpf_netns_link

On Wed, Jul 09, 2025 at 11:08 AM +08, Tao Chen wrote:
> Use attach_type in bpf_link, and remove it in bpf_netns_link.
>
> Acked-by: Jiri Olsa <jolsa@...nel.org>
> Signed-off-by: Tao Chen <chen.dylane@...ux.dev>
> ---
>  kernel/bpf/net_namespace.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/bpf/net_namespace.c b/kernel/bpf/net_namespace.c
> index 63702c86275..6d27bd97c95 100644
> --- a/kernel/bpf/net_namespace.c
> +++ b/kernel/bpf/net_namespace.c
> @@ -11,7 +11,6 @@
>  
>  struct bpf_netns_link {
>  	struct bpf_link	link;
> -	enum bpf_attach_type type;
>  	enum netns_bpf_attach_type netns_type;
>  
>  	/* We don't hold a ref to net in order to auto-detach the link

Nit: Doesn't that create a hole? Maybe move netns_type to the end.

[...]