linux-kernel - Re: [PATCH] firmware: arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250709-olivine-macaw-of-rain-94cb43@sudeepholla>
Date: Wed, 9 Jul 2025 10:48:56 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Cristian Marussi <cristian.marussi@....com>,
	Sudeep Holla <sudeep.holla@....com>, Peng Fan <peng.fan@....com>,
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Use modern PM ops

On Tue, Jul 08, 2025 at 04:19:50PM -0700, Nathan Chancellor wrote:
> When building without CONFIG_PM_SLEEP (e.g., with hexagon or s390),
> there is a warning because scmi_system_power_resume() is not used due to
> how SET_SYSTEM_SLEEP_PM_OPS is defined:
> 
>   drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error: 'scmi_system_power_resume' defined but not used [-Werror=unused-function]
>     363 | static int scmi_system_power_resume(struct device *dev)
>         |            ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Use the moderm SYSTEM_SLEEP_PM_OPS to resolve the warnings, which is
> what SET_SYSTEM_SLEEP_PM_OPS ultimately expands to, so there is no
> change in behavior.
> 

If it is OK, I plan to pick [1] which additional uses pm_sleep_ptr()
to avoid additional warnings.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/all/20250709070107.1388512-1-arnd@kernel.org