linux-kernel - Re: [PATCH v2] PCI: endpoint: pci-epf-vntb: fix MW2 configfs ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175205817756.10340.17764622266957166451.b4-ty@kernel.org>
Date: Wed,  9 Jul 2025 16:21:28 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Jon Mason <jdmason@...zu.us>,
	Dave Jiang <dave.jiang@...el.com>,
	Allen Hubbe <allenbh@...il.com>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Frank Li <Frank.Li@....com>,
	Jerome Brunet <jbrunet@...libre.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
	ntb@...ts.linux.dev,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: pci-epf-vntb: fix MW2 configfs ID


On Wed, 09 Jul 2025 10:20:39 +0200, Jerome Brunet wrote:
> The ID associated with MW2 configfs entry is wrong.
> 
> Trying to use MW2 will overwrite the existing BAR setup associated with
> MW1.
> 
> Just put the correct ID for MW2 to fix the situation
> 
> [...]

Squashed to the offending commit! I also fixed below sparse warnings by removing
the __iomem qualifier for 'mw_addr':

drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17: warning: incorrect type in assignment (different address spaces)
drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    expected void [noderef] __iomem *mw_addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    got void *
drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21: warning: incorrect type in assignment (different address spaces)
drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    expected unsigned int [usertype] *epf_db
drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    got void [noderef] __iomem *mw_addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38: warning: incorrect type in argument 2 (different address spaces)
drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    expected void *addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    got void [noderef] __iomem *mw_addr

Best regards,
-- 
Manivannan Sadhasivam <mani@...nel.org>