linux-kernel - Re: [PATCH] ipmi: Use dev_warn_ratelimited() for incorrect message warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG-6gtCvsowPbH8v@mail.minyard.net>
Date: Thu, 10 Jul 2025 08:05:06 -0500
From: Corey Minyard <corey@...yard.net>
To: Breno Leitao <leitao@...ian.org>
Cc: openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	kernel-team@...a.com
Subject: Re: [PATCH] ipmi: Use dev_warn_ratelimited() for incorrect message
 warnings

On Thu, Jul 10, 2025 at 05:57:26AM -0700, Breno Leitao wrote:
> During BMC firmware upgrades on live systems, the ipmi_msghandler
> generates excessive "BMC returned incorrect response" warnings
> while the BMC is temporarily offline. This can flood system logs
> in large deployments.

So the BMC is returning bogus messages during an upgrade?  That
sounds like a bug in the BMC, it should either work or be
quiescent.  Returning incorrect data can result in bad things
happening.

But, as many thing IPMI, we have to accommodate bad designs.
This change is probably a good idea, anyway.

Queued for next merge window.

Thanks,

-corey

> 
> Replace dev_warn() with dev_warn_ratelimited() to throttle these
> warnings and prevent log spam during BMC maintenance operations.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 064944ae9fdc3..8e9050f99e9ef 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -4607,10 +4607,10 @@ static int handle_one_recv_msg(struct ipmi_smi *intf,
>  		 * The NetFN and Command in the response is not even
>  		 * marginally correct.
>  		 */
> -		dev_warn(intf->si_dev,
> -			 "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n",
> -			 (msg->data[0] >> 2) | 1, msg->data[1],
> -			 msg->rsp[0] >> 2, msg->rsp[1]);
> +		dev_warn_ratelimited(intf->si_dev,
> +				     "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n",
> +				     (msg->data[0] >> 2) | 1, msg->data[1],
> +				     msg->rsp[0] >> 2, msg->rsp[1]);
>  
>  		goto return_unspecified;
>  	}
> 
> ---
> base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
> change-id: 20250710-ipmi_ratelimit-7e1af5170c57
> 
> Best regards,
> --  
> Breno Leitao <leitao@...ian.org>
>