linux-kernel - Re: [PATCH 03/10] mm/mremap: put VMA check and prep logic into helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ad9d952-dffc-4766-ad07-de31ede0889a@suse.cz>
Date: Thu, 10 Jul 2025 15:10:48 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Peter Xu <peterx@...hat.com>, Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Jann Horn <jannh@...gle.com>,
 Pedro Falcato <pfalcato@...e.de>, Rik van Riel <riel@...riel.com>,
 linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 03/10] mm/mremap: put VMA check and prep logic into helper
 function

On 7/7/25 07:27, Lorenzo Stoakes wrote:
> Rather than lumping everything together in do_mremap(), add a new helper
> function, check_prep_vma(), to do the work relating to each VMA.
> 
> This further lays groundwork for subsequent patches which will allow for
> batched VMA mremap().
> 
> Additionally, if we set vrm->new_addr == vrm->addr when prepping the VMA,
> this avoids us needing to do so in the expand VMA mlocked case.
> 
> No functional change intended.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>