linux-kernel - Re: [PATCH for-netdev v2 2/2] PCI: hv: Switch to msi_create_parent_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505fa40f-ba51-4f6e-9517-af3e7596a1cb@redhat.com>
Date: Thu, 10 Jul 2025 15:11:36 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: "open list:Hyper-V/Azure CORE AND DRIVERS"
 <linux-hyperv@...r.kernel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Michael Kelley <mhklinux@...look.com>,
 Nam Cao <namcao@...utronix.de>, Simon Horman <horms@...nel.org>,
 Marc Zyngier <maz@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 Thomas Gleixner <tglx@...utronix.de>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for-netdev v2 2/2] PCI: hv: Switch to
 msi_create_parent_irq_domain()

On 7/7/25 8:49 PM, Michael Kelley wrote:
> From: Nam Cao <namcao@...utronix.de> Sent: Monday, July 7, 2025 1:20 AM
>>
>> Move away from the legacy MSI domain setup, switch to use
>> msi_create_parent_irq_domain().
>>
>> While doing the conversion, I noticed that hv_compose_msi_msg() is doing
>> more than it is supposed to (composing message). This function also
>> allocates and populates struct tran_int_desc, which should be done in
>> hv_pcie_domain_alloc() instead. It works, but it is not the correct design.
>> However, I have no hardware to test such change, therefore I leave a TODO
>> note.
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
>> Signed-off-by: Nam Cao <namcao@...utronix.de>
> 
> [Adding linux-hyperv@...r.kernel.org so that the Linux on Hyper-V folks
> have visibility.]

I think this series could go via netdev, to simplify the later merge,
but it would be better to have explicit ack from Hyper-V people.

Adding more Microsoft folks.

/P