linux-kernel - Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d870b11c-39e2-4b7a-a368-13b1c4b5a7c8@kernel.org>
Date: Thu, 10 Jul 2025 15:33:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 sakari.ailus@...ux.intel.com, krzk+dt@...nel.org,
 kieran.bingham@...asonboard.com
Cc: dave.stevenson@...pberrypi.com, pratap.nirujogi@....com,
 laurent.pinchart@...asonboard.com, tarang.raval@...iconsignals.io,
 Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Ricardo Ribalda <ribalda@...omium.org>, André Apitzsch
 <git@...tzsch.eu>, Arnd Bergmann <arnd@...db.de>,
 Dongcheng Yan <dongcheng.yan@...el.com>,
 Jingjing Xiong <jingjing.xiong@...el.com>,
 Matthias Fend <matthias.fend@...end.at>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Sylvain Petinot <sylvain.petinot@...s.st.com>,
 Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Hans de Goede <hansg@...nel.org>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor

On 10/07/2025 15:10, Hardevsinh Palaniya wrote:
> +
> +  clocks:
> +    items:
> +      - description: XVCLK clock
> +
> +  clock-names:
> +    items:
> +      - const: xvclk

You don't use clock names here and example, so just drop the property.

With this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

---

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof