linux-kernel - Re: [PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document stylus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175215452823.2039713.12986563371135237841.robh@kernel.org>
Date: Thu, 10 Jul 2025 08:35:28 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>, 
 Charles Wang <charles.goodix@...il.com>, devicetree@...r.kernel.org, 
 Hans de Goede <hansg@...nel.org>, Luke Jones <luke@...nes.dev>, 
 Dmitry Torokhov <dmitry.torokhov@...il.com>, 
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
 Conor Dooley <conor+dt@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>, 
 Neil Armstrong <neil.armstrong@...aro.org>, linux-input@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Ingo Molnar <mingo@...nel.org>, Eric Biggers <ebiggers@...nel.org>, 
 Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
 Len Brown <len.brown@...el.com>, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document
 stylus support

On Thu, 10 Jul 2025 19:57:32 +0800, Pengyu Luo wrote:
> Document stylus support. Optional support for DT properties:
>   - `goodix,stylus-enable`
>   - `goodix,stylus-pressure-level`
>   - `touchscreen-x-mm`
>   - `touchscreen-y-mm`
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@...il.com>
> ---
>  .../bindings/input/touchscreen/goodix,gt9916.yaml    | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml: properties:goodix,stylus-enable: 'description' is a dependency of 'type'
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250710115733.226670-2-mitltlatltl@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.