linux-kernel - Re: [PATCH v2] dm-verity: remove support for asynchronous hashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <130123c7-da36-4ac9-8366-5ad811360eee@gmail.com>
Date: Thu, 10 Jul 2025 18:18:58 +0200
From: Milan Broz <gmazyland@...il.com>
To: Bart Van Assche <bvanassche@....org>, Eric Biggers <ebiggers@...nel.org>,
 dm-devel@...ts.linux.dev, Alasdair Kergon <agk@...hat.com>,
 Mike Snitzer <snitzer@...nel.org>, Mikulas Patocka <mpatocka@...hat.com>
Cc: linux-kernel@...r.kernel.org, Gilad Ben-Yossef <gilad@...yossef.com>,
 Ard Biesheuvel <ardb@...nel.org>, "Jason A . Donenfeld" <Jason@...c4.com>,
 Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH v2] dm-verity: remove support for asynchronous hashes

On 7/10/25 5:55 PM, Bart Van Assche wrote:
> On 7/10/25 1:28 AM, Milan Broz wrote:
>> Just one nitpick - could you please increase minor version of dm-
>> verity target, so we have information in debug log that it is a
>> patched version?
> Others are convinced that version numbers have no place in the upstream
> kernel and that all version information should be removed from upstream
> kernel drivers.

Others are convinced that this information from the log is very useful,
which is why we report all versions as the first step in cryptsetup tests.

This says nothing about detecting the availability of certain functions -
that is done by just trying the ioctl.
That was the discussion you are probably referring to.

I understand what you are saying, but device-mapper was constructed with
some logic that allows many variants of mapping table parameters and
reporting version is very useful to reproduce compatibility issues.
It saved me a lot of time.

Thanks,
Milan