linux-kernel - Re: [PATCH v7 05/12] pinctrl: s32cc: change to "devm_pinctrl_register_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG/pV0m8vNJ9isGu@lizhi-Precision-Tower-5810>
Date: Thu, 10 Jul 2025 12:24:55 -0400
From: Frank Li <Frank.li@....com>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, chester62515@...il.com,
	mbrugger@...e.com, Ghennadi.Procopciuc@....com,
	larisa.grigore@....com, lee@...nel.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, festevam@...il.com, aisheng.dong@....com,
	ping.bai@....com, gregkh@...uxfoundation.org, rafael@...nel.org,
	srini@...nel.org, linux-gpio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, s32@....com,
	clizzi@...hat.com, aruizrui@...hat.com, eballetb@...hat.com,
	echanude@...hat.com, kernel@...gutronix.de, imx@...ts.linux.dev,
	vincent.guittot@...aro.org
Subject: Re: [PATCH v7 05/12] pinctrl: s32cc: change to
 "devm_pinctrl_register_and_init"

On Thu, Jul 10, 2025 at 05:20:28PM +0300, Andrei Stefanescu wrote:
> Switch from "devm_pinctrl_register" to "devm_pinctrl_register_and_init"
> and "pinctrl_enable" since this is the recommended way.
>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>

Reviewed-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/pinctrl/nxp/pinctrl-s32cc.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> index c90cd96a9dc4..c03dac643cb3 100644
> --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> @@ -973,10 +973,10 @@ int s32_pinctrl_probe(struct platform_device *pdev,
>  		return dev_err_probe(&pdev->dev, ret,
>  				     "Fail to probe dt properties\n");
>
> -	ipctl->pctl = devm_pinctrl_register(&pdev->dev, s32_pinctrl_desc,
> -					    ipctl);
> -	if (IS_ERR(ipctl->pctl))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(ipctl->pctl),
> +	ret = devm_pinctrl_register_and_init(&pdev->dev, s32_pinctrl_desc,
> +					     ipctl, &ipctl->pctl);
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
>  				     "Could not register s32 pinctrl driver\n");
>
>  #ifdef CONFIG_PM_SLEEP
> @@ -989,7 +989,12 @@ int s32_pinctrl_probe(struct platform_device *pdev,
>  		return -ENOMEM;
>  #endif
>
> -	dev_info(&pdev->dev, "initialized s32 pinctrl driver\n");
> +	ret = pinctrl_enable(ipctl->pctl);
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
> +				     "Failed to enable pinctrl\n");
> +
> +	dev_info(&pdev->dev, "Initialized S32 pinctrl driver\n");
>
>  	return 0;
>  }
> --
> 2.45.2
>