linux-kernel - Re: [PATCH v8 2/6] mfd: pf1550: add core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG_0K2qN06JHS0__@fedora>
Date: Thu, 10 Jul 2025 13:11:07 -0400
From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sebastian Reichel <sre@...nel.org>, Frank Li <Frank.li@....com>,
	imx@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	linux-pm@...r.kernel.org, Abel Vesa <abelvesa@...nel.org>,
	Abel Vesa <abelvesa@...ux.com>, Robin Gong <b38343@...escale.com>,
	Robin Gong <yibin.gong@....com>,
	Enric Balletbo i Serra <eballetbo@...il.com>
Subject: Re: [PATCH v8 2/6] mfd: pf1550: add core driver

On Thu, Jul 10, 2025 at 02:54:38PM +0000, Sean Nyekjaer wrote:
> > +	/* Regulator DVS */
> > +	ret = pf1550_read_otp(pf1550, PF1550_OTP_SW2_SW3, &otp_data);
> > +	if (ret)
> > +		return ret;
> > +
> > +	/* When clear, DVS should be enabled */
> > +	if (!(otp_data & OTP_DVS_ENB))
> > +		pf1550->dvs_enb = true;
> > +
> 
> Thanks for upstreaming this :)
> 
> We need to handle DVS for SW1 here.
> I'm using the A6 variant that have DVS enabled for SW1 and disabled for
> SW2.
> The A1 variant have DVS for SW1 disabled...

I can add checking of the OTP for SW1 in the next patchset.

Thanks,
Sam