linux-kernel - Re: [PATCH v8 3/6] regulator: pf1550: add support for regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG_4ic277eGBgQb0@fedora>
Date: Thu, 10 Jul 2025 13:29:45 -0400
From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sebastian Reichel <sre@...nel.org>, Frank Li <Frank.li@....com>,
	imx@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	linux-pm@...r.kernel.org, Abel Vesa <abelvesa@...nel.org>,
	Abel Vesa <abelvesa@...ux.com>, Robin Gong <b38343@...escale.com>,
	Robin Gong <yibin.gong@....com>,
	Enric Balletbo i Serra <eballetbo@...il.com>
Subject: Re: [PATCH v8 3/6] regulator: pf1550: add support for regulator

On Thu, Jul 10, 2025 at 05:11:14PM +0000, Sean Nyekjaer wrote:
> > > > +	for (i = 0; i < ARRAY_SIZE(pf1550_regulators); i++) {
> > > > +		struct regulator_desc *desc;
> > > > +
> > > > +		desc = &info->regulator_descs[i].desc;
> > > > +
> > > > +		if (desc->id == PF1550_SW2 && pf1550->dvs_enb) {
> > >
> > > We should enter here if dvs_enb == false.
> > > My A6 variant reported 0.625V instead of the correct 1.35V
> > >
> > Yeah, that would happen with the current if statement.
> > 
> > Since dvs_enb is true when DVS is enabled (OTP_SW2_DVS_ENB == 0), I should
> > modify the if statment to:
> > (desc->id == PF1550_SW2 && !pf1550->dvs_enb) /* OTP_SW2_DVS_ENB == 1 */
> 
> -		if (desc->id == PF1550_SW2 && pf1550->dvs_enb) {
> +		if (desc->id == PF1550_SW2 && !pf1550->dvs_enb) {
> 
> Yes that's what I have been running my tests with :)
> 
> I will continue with testing the onkey and battery charger
>
Thanks for testing!
> > 
> > I think that would be a more readable solution.
> > > > +			/* OTP_SW2_DVS_ENB == 1? */
> > > > +			desc->volt_table = pf1550_sw12_volts;
> > > > +			desc->n_voltages = ARRAY_SIZE(pf1550_sw12_volts);
> > > > +			desc->ops = &pf1550_sw1_ops;
> > > > +		}
> > > >

Thanks,
Sam