linux-kernel - Re: [RFC PATCH v8 04/35] KVM: x86: Rename VEC_POS/REG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1baa9ee-baca-44ee-b777-fd0bfa177032@amd.com>
Date: Thu, 10 Jul 2025 09:07:32 +0530
From: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: linux-kernel@...r.kernel.org, bp@...en8.de, tglx@...utronix.de,
 mingo@...hat.com, dave.hansen@...ux.intel.com, Thomas.Lendacky@....com,
 nikunj@....com, Santosh.Shukla@....com, Vasant.Hegde@....com,
 Suravee.Suthikulpanit@....com, David.Kaplan@....com, x86@...nel.org,
 hpa@...or.com, peterz@...radead.org, pbonzini@...hat.com,
 kvm@...r.kernel.org, kirill.shutemov@...ux.intel.com, huibo.wang@....com,
 naveen.rao@....com, kai.huang@...el.com
Subject: Re: [RFC PATCH v8 04/35] KVM: x86: Rename VEC_POS/REG_POS macro
 usages



On 7/9/2025 7:39 PM, Sean Christopherson wrote:
> On Wed, Jul 09, 2025, Neeraj Upadhyay wrote:
>> @@ -736,12 +735,12 @@ EXPORT_SYMBOL_GPL(kvm_apic_clear_irr);
>>  
>>  static void *apic_vector_to_isr(int vec, struct kvm_lapic *apic)
>>  {
>> -	return apic->regs + APIC_ISR + REG_POS(vec);
>> +	return apic->regs + APIC_ISR + APIC_VECTOR_TO_REG_OFFSET(vec);
>>  }
>>  
>>  static inline void apic_set_isr(int vec, struct kvm_lapic *apic)
>>  {
>> -	if (__test_and_set_bit(VEC_POS(vec), apic_vector_to_isr(vec, apic)))
>> +	if (__test_and_set_bit(APIC_VECTOR_TO_BIT_NUMBER(vec), apic_vector_to_isr(vec, apic)))
>>  		return;
>>  
>>  	/*
>> @@ -784,7 +783,7 @@ static inline int apic_find_highest_isr(struct kvm_lapic *apic)
>>  
>>  static inline void apic_clear_isr(int vec, struct kvm_lapic *apic)
>>  {
>> -	if (!__test_and_clear_bit(VEC_POS(vec), apic_vector_to_isr(vec, apic)))
>> +	if (!__test_and_clear_bit(APIC_VECTOR_TO_BIT_NUMBER(vec), apic_vector_to_isr(vec, apic)))
>>  		return;
>>  
>>  	/*
> 
> Almost forgot.  I'd prefer to wrap these two, i.e.
> 
> 	if (__test_and_set_bit(APIC_VECTOR_TO_BIT_NUMBER(vec),
> 			       apic_vector_to_isr(vec, apic)))
> 		return;
> 
> and
> 
> 	if (!__test_and_clear_bit(APIC_VECTOR_TO_BIT_NUMBER(vec),
> 				  apic_vector_to_isr(vec, apic)))
> 		return;

Ok. I have updated it for next version here:

https://github.com/AMDESE/linux-kvm/commits/savic-guest-latest
commit 862ee49


- Neeraj