linux-kernel - Re: [PATCH] wifi: mt76: fix potential memory leak in mt76_wmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <354d249c-fd85-4090-af49-25d154f4be24@kernel.org>
Date: Thu, 10 Jul 2025 07:47:25 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Abdun Nihaal <abdun.nihaal@...il.com>, nbd@....name
Cc: lorenzo@...nel.org, ryder.lee@...iatek.com, shayne.chen@...iatek.com,
 sean.wang@...iatek.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, kvalo@...nel.org, toke@...e.dk,
 jeff.johnson@....qualcomm.com, u.kleine-koenig@...libre.com,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] wifi: mt76: fix potential memory leak in
 mt76_wmac_probe()

On 09. 07. 25, 16:55, Abdun Nihaal wrote:
> In mt76_wmac_probe(), when the mt76_alloc_device() call succeeds, memory
> is allocated for both struct ieee80211_hw and a workqueue. However, on
> the error path, the workqueue is not freed. Fix that by calling
> mt76_free_device() on the error path.
> 
> Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688")
> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>

I am not sure, why I am CCed, but makes sense anyway (free the one 
obtained by alloc_ordered_workqueue() in mt76_alloc_device()):

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

-- 
js
suse labs