linux-kernel - Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB3519636199BBE7E185798242FF48A@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 10 Jul 2025 07:18:55 +0000
From: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>
CC: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>, Mauro Carvalho
 Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>, Ricardo Ribalda
	<ribalda@...omium.org>, André Apitzsch <git@...tzsch.eu>,
	Hans de Goede <hansg@...nel.org>, Sylvain Petinot
	<sylvain.petinot@...s.st.com>, Jingjing Xiong <jingjing.xiong@...el.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Dongcheng Yan
	<dongcheng.yan@...el.com>, Heimir Thor Sverrisson
	<heimir.sverrisson@...il.com>, Matthias Fend <matthias.fend@...end.at>, Arnd
 Bergmann <arnd@...db.de>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	You-Sheng Yang <vicamo.yang@...onical.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor

> On 08/07/2025 12:25, Hardevsinh Palaniya wrote:
> > +
> > +  clocks:
> > +    items:
> > +      - description: XVCLK clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: xvclk
> > +
> > +  AVDD-supply:
> 
> Use lowercase everywhere.
> 
> > +    description: Analog Domain Power Supply
> > +
> > +  DOVDD-supply:
> > +    description: I/O Domain Power Supply
> > +
> > +  DVDD-supply:
> > +    description: Digital Domain Power Supply
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description: Reset Pin GPIO Control (active low)
> > +
> > +  pwdn-gpios:
> 
> Use instead recommended name from the gpio-consumer-common.yaml.

As you mentioned in patch 2/2, this pin is not a typical power-down control
but behaves more like a power-on pin Based on this, I think enable-gpios 
from gpio-consumer-common.yaml is a suitable choice here.

I will use enable-gpios and add a clear description for its usage in the binding. 

Please let me know if you would still prefer poweron-gpios. In that case, 
do I need to add poweron-gpios to the gpio-consumer-common.yaml file?

Best Regards,
Hardev