linux-kernel - Re: [PATCH v3] NFS: Fixup allocation flags for nfsiod's __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG9qCtldrjhqW-s7@infradead.org>
Date: Thu, 10 Jul 2025 00:21:46 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Benjamin Coddington <bcodding@...hat.com>
Cc: Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Laurence Oberman <loberman@...hat.com>,
	Jeff Layton <jlayton@...nel.org>
Subject: Re: [PATCH v3] NFS: Fixup allocation flags for nfsiod's __GFP_NORETRY

On Wed, Jul 09, 2025 at 09:47:43PM -0400, Benjamin Coddington wrote:
> If the NFS client is doing writeback from a workqueue context, avoid using
> __GFP_NORETRY for allocations if the task has set PF_MEMALLOC_NOIO or
> PF_MEMALLOC_NOFS.  The combination of these flags makes memory allocation
> failures much more likely.

Can we take a step back and figre out why this blanket usage of
__GFP_NORETRY exists at all?