linux-kernel - Re: [PATCH v2 2/2] phy: dw-dphy-rx: Add dt bindings for Synopsys MIPI D-PHY RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250710-dainty-tarsier-from-hyperborea-ecf9d3@krzk-bin>
Date: Thu, 10 Jul 2025 09:24:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Karthik Poduval <kpoduval@...126.com>
Cc: jyxiong@...zon.com, miguel.lopes@...opsys.com, anishkmr@...zon.com, 
	vkoul@...nel.org, kishon@...nel.org, linux-kernel@...r.kernel.org, 
	linux-phy@...ts.infradead.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] phy: dw-dphy-rx: Add dt bindings for Synopsys
 MIPI D-PHY RX

On Wed, Jul 09, 2025 at 07:42:21PM -0700, Karthik Poduval wrote:
> +---
> +$id: http://devicetree.org/schemas/phy/snps,dw-dphy-rx.yaml#

Filename and id should match compatible.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys Designware MIPI D-PHY RX
> +
> +maintainers:
> +  - Karthik Poduval <kpoduval@...126.com>
> +  - Jason Xiong <jyxiong@...zon.com>
> +  - Miguel Lopes <miguel.lopes@...opsys.com
> +
> +description: |
> +  These are the bindings for Synopsys Designware MIPI DPHY RX phy driver.
> +  Currently only supported phy version is v1.2.
> +
> +properties:
> +  compatible:
> +    const: snps,dw-dphy-1p2

You should rather use SoC compatibles.

> +
> +  '#phy-cells':
> +    const: 0
> +
> +  reg:
> +    minItems: 2
> +    maxItems: 2

List the items instead

And fix the order, reg goes second.

> +
> +required:
> +  - compatible
> +  - '#phy-cells'
> +  - reg

Here as well

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dw_dphy_rx: dw-dphy@...000040 {

phy@

> +        compatible = "snps,dw-dphy-1p2";
> +        #phy-cells = <0>;
> +        reg = <0x0 0x90000040 0x0 0x20>, <0x0 0x90001000 0x0 0x8>;
> +        status = "disabled";

No, drop. And fix the order of properties, see DTS coding style.

> +    };

Best regards,
Krzysztof