linux-kernel - Re: [PATCH 1/2] erofs: allow readdir() to be interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4ab45c9-b3d2-4807-954d-1bd7d38b7242@linux.alibaba.com>
Date: Thu, 10 Jul 2025 15:41:49 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Chao Yu <chao@...nel.org>, xiang@...nel.org
Cc: linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>,
 Sandeep Dhavale <dhavale@...gle.com>, Hongbo Li <lihongbo22@...wei.com>
Subject: Re: [PATCH 1/2] erofs: allow readdir() to be interrupted



On 2025/7/10 15:36, Chao Yu wrote:
> In a quick slow device, readdir() may loop for long time in large
> directory, let's give a chance to allow it to be interrupted by
> userspace.
> 
> Signed-off-by: Chao Yu <chao@...nel.org>

Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

> ---
>   fs/erofs/dir.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c
> index 2fae209d0274..cff61c5a172b 100644
> --- a/fs/erofs/dir.c
> +++ b/fs/erofs/dir.c
> @@ -58,6 +58,13 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
>   		struct erofs_dirent *de;
>   		unsigned int nameoff, maxsize;
>   
> +		/* allow readdir() to be interrupted */

Hi Chao,

It seems that comment is unnecessary since the following code
is obvious, if you have no objection I will remove this
comment when applying.

Thanks,
Gao Xiang