linux-kernel - Re: [PATCH] ALSA: compress_offload: tighten ioctl command number checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG9vrq8kRqfigzgm@vaman>
Date: Thu, 10 Jul 2025 13:15:50 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
	Arnd Bergmann <arnd@...db.de>,
	Shengjiu Wang <shengjiu.wang@...il.com>,
	Yu Jiaoliang <yujiaoliang@...o.com>,
	Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
	Al Viro <viro@...iv.linux.org.uk>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: compress_offload: tighten ioctl command number
 checks

On 10-07-25, 08:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The snd_compr_ioctl() ignores the upper 24 bits of the ioctl command
> number and only compares the number of the ioctl command, which can
> cause unintended behavior if an application tries to use an unsupprted
> command that happens to have the same _IOC_NR() value.
> 
> Remove the truncation to the low bits and compare the entire ioctl
> command code like every other driver does.
> 
> Fixes: b21c60a4edd2 ("ALSA: core: add support for compress_offload")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I could not find any indication on why this driver did this in
> the first place, it already was this way in the original commit
> back in 2011.

I guess I would have started from a bad template back then!
Thanks for fixing this

Acked-by: Vinod Koul <vkoul@...nel.org>
-- 
~Vinod